Add option to exclude globs from given input #4480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhendric
approved these changes
Jun 25, 2023
Member
rhendric
left a comment
rhendric
left a comment
There was a problem hiding this comment.
Looks good; I can certainly see the use for this.
thomashoneyman
approved these changes
Jun 26, 2023
JordanMartinez
approved these changes
Jun 26, 2023
Contributor
|
CI seems to be stalled due to the ARM64 CI. |
Contributor
|
cc @f-f |
Member
|
Sorry I'm on holiday and I see this only now - fortunately I have a computer with me so I can ssh to the machine and see what's up.. |
Member
|
The macos ARM64 runner disappeared from the configured runners so I had to reinstall it from scratch - not sure if anyone actively deleted it, but I'd ask to refrain from doing so if that was the case. I restarted the build and everything is now back to green. |
f-f
approved these changes
Jul 3, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the possibility to remove files from the globs passed to the compiler
Colocation means that we can keep related files close together in our file system.
So instead of recreating the whole module tree in a
testfolder it'd be possible to structure the project as such:The motivation for supporting colocation can be followed here.
However, it's currently not possible to exclude globs from publishing. I've opened PRs to add this functionality to the new registry and spago.
Verity raised a good point, however, in that it should also be easy to pass only the files that shall be published to the compiler (for example to not include test dependencies).
This PR adds this possibility.
Note that this does not add a way to exclude globs from the IDE or PSCI, because I don't see the use case for it and wanted to keep the change small. It could also be added later.
Checklist: