Skip to content

Add packages from zudov#679

Closed
thomashoneyman wants to merge 1 commit into
masterfrom
zudov-packages
Closed

Add packages from zudov#679
thomashoneyman wants to merge 1 commit into
masterfrom
zudov-packages

Conversation

@thomashoneyman

@thomashoneyman thomashoneyman commented Aug 30, 2020

Copy link
Copy Markdown
Member

This PR adds the websocket-simple and var packages by @zudov. They are already published on Bower and this adds them to the package sets as well.

@thomashoneyman

thomashoneyman commented Aug 30, 2020

Copy link
Copy Markdown
Member Author

Uh oh:

Error found:
at .spago/websocket-moderate/v7.0.2/src/WebSocket.purs:1:1 - 33:28 (line 1, column 1 - line 33, column 28)

  Module WebSocket has been defined multiple times


See https://github.com/purescript/documentation/blob/master/errors/DuplicateModule.md for more information,
or to contribute content related to this error.

I'm not sure the best thing to do about this. We don't have a proper solution for namespacing these.

@f-f

f-f commented Aug 30, 2020

Copy link
Copy Markdown
Member

These packages can be safely regarded as unmaintained since long, so we should probably just fork them if we think there's any value in the code

@thomashoneyman

thomashoneyman commented Aug 30, 2020

Copy link
Copy Markdown
Member Author

Understood. I'm going to close this PR with that in mind.

@thomashoneyman thomashoneyman deleted the zudov-packages branch August 30, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thomashoneyman @f-f @th-awake