fix(launcher): do not add --disable-gpu on OSX and Linux#2908
Merged
aslushnikov merged 1 commit intopuppeteer:masterfrom Jul 19, 2018
Merged
fix(launcher): do not add --disable-gpu on OSX and Linux#2908aslushnikov merged 1 commit intopuppeteer:masterfrom
aslushnikov merged 1 commit intopuppeteer:masterfrom
Conversation
This patch conditionally adds the `--disable-gpu` flag if only we run headless on windows. Fixes puppeteer#1260.
JoelEinbinder
approved these changes
Jul 19, 2018
hadley
added a commit
to rstudio/chromote
that referenced
this pull request
Jan 30, 2024
It is no longer needed as the underlying bugs have been fixed in chromium (for multiple years). This flag was dropped in puppeteer in puppeteer/puppeteer#2908 and puppeteer/puppeteer#4523.
wch
pushed a commit
to rstudio/chromote
that referenced
this pull request
Jan 30, 2024
It is no longer needed as the underlying bugs have been fixed in chromium (for multiple years). This flag was dropped in puppeteer in puppeteer/puppeteer#2908 and puppeteer/puppeteer#4523.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch conditionally adds the
--disable-gpuflag if only werun headless on windows.
Fixes #1260.