fix: allow multiple navigations to happen in LifecycleWatcher (#8826)

OrKoN · web-flow · commit 341b669a5e45 · 2022-08-22T14:51:58.000Z
There is no repro but it looks like sometimes the backend reports two navigation requests. This PR changes the logic to allow that instead of failing as it seems that failing is a bigger issue than handling multiple navigation requests. Closes #8811
diff --git a/src/common/LifecycleWatcher.ts b/src/common/LifecycleWatcher.ts
@@ -179,9 +179,10 @@ export class LifecycleWatcher {
       return;
     }
     this.#navigationRequest = request;
-    this.#navigationResponseReceived?.reject(
-      new Error('New navigation request was received')
-    );
+    // Resolve previous navigation response in case there are multiple
+    // navigation requests reported by the backend. This generally should not
+    // happen by it looks like it's possible.
+    this.#navigationResponseReceived?.resolve();
     this.#navigationResponseReceived = createDeferredPromise();
     if (request.response() !== null) {
       this.#navigationResponseReceived?.resolve();
