Repository navigation
fix(openapi): preserve simple path array separators - #496
Merged
punkpeye merged 2 commits intoNov 5, 2026
Merged
Conversation
Owner
|
Pushed a small follow-up: the |
|
🎉 This PR is included in version 4.24.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple-style path arrays currently escape the entire stringified array, so
["blue,green", "red/white"]requests/colors/blue%2Cgreen%2Cred%2Fwhite. Encode each scalar item before joining with commas instead, producing/colors/blue%2Cgreen,red%2Fwhiteas required by OpenAPI simple serialization.This covers omitted/default
styleand eitherexplodeflag. Regression tests exercise referenced parameters through generated MCP tools, reserved characters, empty items/arrays, repeated placeholders and the existing dot-segment guard. Scalar values and unsupported path styles keep their current behavior; no dependencies change.Validation on macOS:
pnpm lintandpnpm testpass, with 1465 tests across 85 files on each version.pnpm test:openapipasses all 15 benchmark/live tests. The existing helper warned about PostHog's unstable schema hash and proceeded with the freshly downloaded spec; no pins changed.pnpm buildandnpm pack --dry-run --jsonpass. The package has 53 files, with no temporary tools or fixtures.Prepared with AI assistance and independently reviewed before publication.