Repository navigation
fix: validate draft 2019-09 schemas in jsonSchemaAdapter - #485
Merged
punkpeye merged 1 commit intoNov 2, 2026
Merged
Conversation
|
🎉 This PR is included in version 4.23.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An explicitly declared draft-2019-09 schema currently fails on the first
jsonSchemaAdaptervalidation withno schema with key or ref, even for valid data. The default AJV class only includes draft-07 support.Select the existing AJV 2019 entry point for this dialect. As with draft-2020-12, normalize HTTP and trailing-fragment URI forms only in the compiled copy, preserving the caller's advertised schema.
Add regressions for all four URI forms, valid tuples, tuple types and extra items,
dependentRequired, andunevaluatedProperties. Existing default/draft-07 and draft-2020-12 coverage remains in place.Validation on Node 24:
pnpm buildpnpm lint(Prettier, ESLint, TypeScript, JSR publish dry-run)pnpm test: 1,345 passed across 81 filespnpm test:openapi: 15 passed (the existing PostHog spec pin-drift warning was emitted)AI assistance: prepared with OpenAI Codex.