Repository navigation
fix: keep the last resource template in a registration batch - #478
Merged
punkpeye merged 2 commits intoNov 2, 2026
Merged
Conversation
punkpeye
changed the title
|
🎉 This PR is included in version 4.23.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addResourceTemplates()retained earlier definitions when a batch repeated a template name. MCP sessions kept only the last definition, whileserver.embedded()searched the original array. A tool embeddingdocs://xcould therefore return obsolete content even thoughresources/readreturned the current content; changing the replacement URI also left the obsolete URI embeddable.Apply the existing single-template name replacement semantics to each batch item, then send one list-changed notification. Different template names sharing a URI pattern retain their existing behavior. This complements the resource/tool batch fixes in #476 and #477; it changes only resource-template registration.
Regression cases use an MCP client to read resources and call a tool returning embedded resources, before and after connection, with both unchanged and changed template URIs. They also check unaffected templates, shared URI patterns, and notification count. All four cases fail on the original implementation and pass with the fix.
Validation on Node 24/macOS:
pnpm buildandpnpm lintpass;pnpm test: 1,345 passed;pnpm test:openapi: 15 passed. The network benchmark emitted its existing PostHog schema pin-drift warning and completed successfully.