Repository navigation
fix: replace resources registered under the same URI - #476
Merged
punkpeye merged 2 commits intoOct 27, 2026
Merged
Conversation
Owner
|
Pushed a small cleanup: |
|
🎉 This PR is included in version 4.23.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-registering a resource URI under a new name leaves the old registration in FastMCP's resource list.
resources/readuses the new handler, whileserver.embedded(uri)and tools that call it still return the old content. Removing the new registration can expose the old one again.addResourceandaddResourcesnow replace existing entries by URI as well as by name. Duplicate URIs within a batch keep the last entry, matching the session's resource lookup. Existing same-name replacement behavior is preserved.Regression coverage uses an SDK client over
InMemoryTransportto check direct reads, embedded tool results, and removal. The three new cases fail before the fix.Validation:
pnpm test(81 files, 1261 tests),pnpm lint(including the JSR dry-run), andpnpm buildpass on Node 24 with pnpm 9.pnpm test:openapi: both live Petstore tests passed. The benchmark suite's fixture-download hook timed out after 180 seconds, so its 13 tests did not run. No test timeouts or spec pins were changed.