Socket activation cleanup, fixes, and a doc #942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Keep only the basic known info from imported FD/Socket as keys
* Then with creating listeners in Binders.parse look for available
Sockets using only these details.
This allows socket activation to work with ssl and other listeners
where additional parameters are specified in config. These parameters
could not otherwise be determined from an imported FD which previously
caused lookup/matching to fail, followed by failed startup due to
ports being "already in use" (by the same socket activation).
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Socket activation didn't work for SSL or any listeners specifying additional parameters.
These commits begin with some logging and basic cleanup of the prior socket activation additions. 3030870 fixes socket activation for the additional listener types. And finally I add a docs/systemd.md to give a more complete example of the whole setup.