Fix bug setting worker_directory when using a symlink directory #793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The @cli_options variable is used to reflect the options passed from the command line. The @options variable is the final set of options that will be used by the Runner instance for configuration. When generating the restart data, we want to set the value in the @options hash and not in the @cli_options hash.
|
@evanphx thoughts on this? This bug just caused some downtime for us. |
Author
|
FWIW, we have been running this in production for the past 3 weeks with no issues. |
evanphx
added a commit
that referenced
this pull request
Nov 6, 2015
…-bug Fix bug setting worker_directory when using a symlink directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #770
The @cli_options variable is used to reflect the options passed from the command line.
The @options variable is the final set of options that will be used by the Runner instance
for configuration. When generating the restart data, we want to set the value in the @options
hash and not in the @cli_options hash.