CHG: make jungle for init.d support rbenv #774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
It passed all tests on my OSX but failed for one on travis, I'm looking into it. |
Contributor
Author
|
The error on travis seens like something inside puma, or the build, not the script I modified. So I'ill just ignore it. |
evanphx
added a commit
that referenced
this pull request
Nov 6, 2015
CHG: make jungle for init.d support rbenv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
Inspired by jungle/upstart/puma.conf, I modified jungle/init.d/puma, make it supporting rbenv.
Conditions about rvm and chruby are commented out because I haven't test them.
This commit have passed
bundle exec raketests.Hope it helps event if you decide to support rbenv by different approach and reject this PR.
Best,
Snow