Added on_worker_shutdown mechanism #566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/puma/thread_pool.rb
Outdated
| @@ -176,7 +176,9 @@ def shutdown | |||
|
|
|||
| # Use this instead of #each so that we don't stop in the middle | |||
| # of each and see a mutated object mid #each | |||
| @workers.first.join until @workers.empty? | |||
| if [email protected]? | |||
Member
There was a problem hiding this comment.
Can you fix the formatting of this?
Contributor
Author
There was a problem hiding this comment.
Yes, sorry about that. Should be fixed now.
On Mon, Aug 4, 2014 at 5:11 PM, Evan Phoenix [email protected]
wrote:
In lib/puma/thread_pool.rb:
@@ -176,7 +176,9 @@ def shutdown
# Use this instead of #each so that we don't stop in the middle # of each and see a mutated object mid #each
@workers.first.join until @workers.empty?Can you fix the formatting of this?
—
Reply to this email directly or view it on GitHub
https://github.com/puma/puma/pull/566/files#r15763791.
evanphx
added a commit
that referenced
this pull request
Nov 24, 2014
Added on_worker_shutdown mechanism
|
@sheltond Do you have some sample code where you utilize this for background threads that start cleanly and close gracefully? Just looking to make sure signal hooks are used if needed, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented this because I was having the same problem as johnkchow who opened issue #562: I use a system which does operations in a background thread within a Rails process, and I need to defer the shutdown of Puma worker processes until any background operations are done.
This patch just calls an array of hooks immediately before the worker exits (after it has stopped accepting connections), and blocks until the hooks return.
The user can add an "on_worker_shutdown" section in their Puma configuration file where they can call whatever function they need to block until their background jobs are finished.