Instead of hardcoding dependencies, detect and use what is found #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…platform compatibility.
…nd line argument prefix also used by Visual C++, but that is a fatal compiler error (invalid argument)
evanphx
added a commit
that referenced
this pull request
Oct 16, 2014
Instead of hardcoding dependencies, detect and use what is found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently extconf.rb just hardcodes the build flags. This works for Linuxes and Macs, and on Windows/Mingw, but does not work with Visual C++. This changeset adds detection of available libraries and compatibility with the Visual C++ Toolchain.
This should also simplify building on Windows in general since OpenSSL uses ssleay32 and libeay32 as the library name.
Tested on my Visual C++ 2013 build. Should work with RubyInstaller 2.0.0 also.