lib/rack/handler/puma.rb - relocate and fixup module comment [ci skip] #3495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current location, it's considered a comment attached to `Puma`.
dentarg
approved these changes
Sep 19, 2024
Member
Author
|
Thanks for reviewing. I'm doing my best to not abbreviate variable names, and my comments may not always be clear to someone not familiar with the Puma code base... See the 'Overview' section (almost the top) of https://msp-greg.github.io/puma/Puma.html. Noticed while checking the udpates to puma.io... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the current location, it's considered a comment attached to
Puma.Apologies, I placed the comment in the wrong location in a commit from Feb of 2023...
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.