Skip to content

Conversation

@joshuay03
Copy link
Collaborator

@joshuay03 joshuay03 commented May 2, 2024

Description

Having enabled debug logs at work I thought it would be useful if there was a generic debug log before all the hooks for a type are run.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@dentarg dentarg added feature waiting-for-review Waiting on review from anyone labels Jun 5, 2024
@joshuay03 joshuay03 force-pushed the add-debug-log-before-running-hooks branch from 2bc12f2 to 45528a6 Compare October 16, 2024 11:28
@joshuay03
Copy link
Collaborator Author

joshuay03 commented Oct 16, 2024

Hey @nateberkopec @MSP-Greg @dentarg, I have this PR along with a few other enhancement PRs that I would really appreciate your reviews on when you have the time:

Thanks!

@nateberkopec nateberkopec merged commit 0eb9a49 into puma:master Nov 23, 2024
@joshuay03 joshuay03 deleted the add-debug-log-before-running-hooks branch November 23, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature waiting-for-review Waiting on review from anyone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants