Avoid checking if all workers reached timeout unless idle timeout is configured #3341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An oversight on my part in #3283.
Puma::Cluster#runconstantly checks if all workers have reached their idle timeout even when the feature isn't being used. This change ensures that this check only runs whenidle_timeoutis configured.Also includes a micro-optimisation which ensures the idle workers state hash isn't unnecessarily initialised until actually required (either a worker indicates timeout reached via pipe or
Puma::Cluster#runchecks ifall_workers_idle_timed_out?).All of these changes are covered by existing tests.
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.