Allow to configure both min and max threads as a single number #3309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I may be off, but it seems to be that in the overwhelming majority of use cases, one will want a fixed number of threads rather than a mix/max, and the `--threads` CLI argument already allow to pass a single number. I such I think it would simplify many configs.
Member
|
Some quick tests I ran: ~/src/puma fixed-thread-config
arm64 $ echo 'threads 5; app { [200, {}, ["OK"]] }' | ruby -Ilib bin/puma --config /dev/stdin --port 0 --log-requests
Puma starting in single mode...
* Puma version: 6.4.2 (ruby 3.2.2-p53) ("The Eagle of Durango")
* Min threads: 5
* Max threads: 5
* Environment: development
* PID: 10063
* Listening on http://0.0.0.0:57352
Use Ctrl-C to stop
^C- Gracefully stopping, waiting for requests to finish
=== puma shutdown: 2024-01-09 09:45:08 +0100 ===
- Goodbye!
~/src/puma fixed-thread-config
arm64 $ git co master
Switched to branch 'master'
Your branch is up to date with 'origin/master'.
~/src/puma master
arm64 $ echo 'threads 5; app { [200, {}, ["OK"]] }' | ruby -Ilib bin/puma --config /dev/stdin --port 0 --log-requests
/Users/dentarg/src/puma/lib/puma/dsl.rb:490:in `threads': wrong number of arguments (given 1, expected 2) (ArgumentError)
from /dev/stdin:1:in `_load_from'
from /Users/dentarg/src/puma/lib/puma/dsl.rb:133:in `instance_eval'
from /Users/dentarg/src/puma/lib/puma/dsl.rb:133:in `_load_from'
from /Users/dentarg/src/puma/lib/puma/configuration.rb:239:in `block in load'
from /Users/dentarg/src/puma/lib/puma/configuration.rb:239:in `each'
from /Users/dentarg/src/puma/lib/puma/configuration.rb:239:in `load'
from /Users/dentarg/src/puma/lib/puma/launcher.rb:54:in `initialize'
from /Users/dentarg/src/puma/lib/puma/cli.rb:66:in `new'
from /Users/dentarg/src/puma/lib/puma/cli.rb:66:in `initialize'
from bin/puma:8:in `new'
from bin/puma:8:in `<main>'
~/src/puma master
arm64 $ echo 'app { [200, {}, ["OK"]] }' | ruby -Ilib bin/puma --config /dev/stdin --port 0 --log-requests --threads 5
Puma starting in single mode...
* Puma version: 6.4.2 (ruby 3.2.2-p53) ("The Eagle of Durango")
* Min threads: 5
* Max threads: 5
* Environment: development
* PID: 10371
* Listening on http://0.0.0.0:57366
Use Ctrl-C to stop
^C- Gracefully stopping, waiting for requests to finish
=== puma shutdown: 2024-01-09 09:45:36 +0100 ===
- Goodbye! |
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I may be off, but it seems to be that in the overwhelming majority of use cases, one will want a fixed number of threads rather than a mix/max, and the
--threadsCLI argument already allow to pass a single number.I such I think it would simplify many configs.