Skip to content

Add on_thread_start_hook #3195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nateberkopec merged 2 commits into from
Aug 15, 2023
Merged

Add on_thread_start_hook #3195

nateberkopec merged 2 commits into from
Aug 15, 2023

Conversation

@binarygit
Copy link
Contributor

@binarygit binarygit commented Jul 17, 2023 •
edited
Loading

Description

This PR closes #3192

It provides a before_thread_start hook which can be used to execute code before a thread starts.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@binarygit
Copy link
Contributor Author

binarygit commented Jul 17, 2023

I closely followed @biinari's work on #2920 and I think I have done it correctly but please let me know if I missed something 🙏

@nateberkopec
Copy link
Member

nateberkopec commented Jul 23, 2023

Hey @binarygit, thanks for answering the call and thanks for your first contribution 😄

@dhavalsingh
Copy link
Contributor

dhavalsingh commented Jul 31, 2023

turbo-rails / ubuntu-22.04 Ruby head Rails 7.0 (pull_request) Failing after 2m

This test is failing. Will this PR get merged as it is or can I help so this test also passes?

First time contributing hence the doubt, sorry if it's a basic query.

@dentarg dentarg mentioned this pull request Aug 4, 2023
Closed
7 tasks
@nateberkopec nateberkopec merged commit d62f077 into puma:master Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dentarg dentarg dentarg approved these changes

@nateberkopec nateberkopec nateberkopec approved these changes

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add on_thread_start hook

4 participants

@binarygit @nateberkopec @dhavalsingh @dentarg