Clarify Reactor#initialize #3151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
What's the motivation behind this change? Looks good to me, the only thing I don't understand is the |
Member
Author
|
I really don't like the ternary statement 😆 sitting at RubyKaigi and reading reactor.rb with some spare time... |
Member
Author
|
@dentarg Hopefully this clarifies: |
ning-github
added a commit
to ning-github/puma
that referenced
this pull request
Nov 2, 2024
puma#3151 broke JRuby selector initialization via the following: ``` NIO::Selector.backends.delete(backend) => nil ``` What results is that `::NIO::Selector.new(nil)` is not the same as `::NIO::Selector.new`. The former invokes https://github.com/socketry/nio4r/blob/v2.5.2/ext/nio4r/org/nio4r/Selector.java#L47, which results in an exception being thrown. This PR will restore the reactor initialization to call the intended https://github.com/socketry/nio4r/blob/v2.5.2/ext/nio4r/org/nio4r/Selector.java#L41
7 tasks
ning-github
added a commit
to ning-github/puma
that referenced
this pull request
Nov 2, 2024
puma#3151 broke JRuby selector initialization via the following: ``` NIO::Selector.backends.delete(backend) => nil ``` What results is that `::NIO::Selector.new(nil)` is not the same as `::NIO::Selector.new`. The former invokes https://github.com/socketry/nio4r/blob/v2.5.2/ext/nio4r/org/nio4r/Selector.java#L47, which results in an exception being thrown. This PR will restore the reactor initialization to call the intended https://github.com/socketry/nio4r/blob/v2.5.2/ext/nio4r/org/nio4r/Selector.java#L41
ning-github
added a commit
to ning-github/puma
that referenced
this pull request
Jan 29, 2025
puma#3151 broke JRuby selector initialization via the following: ``` NIO::Selector.backends.delete(backend) => nil ``` What results is that `::NIO::Selector.new(nil)` is not the same as `::NIO::Selector.new`. The former invokes https://github.com/socketry/nio4r/blob/v2.5.2/ext/nio4r/org/nio4r/Selector.java#L47, which results in an exception being thrown. This PR will restore the reactor initialization to call the intended https://github.com/socketry/nio4r/blob/v2.5.2/ext/nio4r/org/nio4r/Selector.java#L41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.