Correctly close app body for all code paths #3002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateberkopec
requested changes
Oct 26, 2022
miharekar
added a commit
to miharekar/visualizer
that referenced
this pull request
Oct 26, 2022
Testing puma/puma#3002 bugfix
MSP-Greg
force-pushed
the
00-issue-2999
branch
from
ddbaceb to
36c3cb2
Compare
MSP-Greg
force-pushed
the
00-issue-2999
branch
from
57d2fa8 to
71dc3d3
Compare
Member
Author
|
Added commit '[CI] Fix two intermittent failures?', see https://github.com/puma/puma/actions/runs/3348499190 |
Member
Author
|
One person stated that this PR fixed the issue re #2999, see comment. Re #3004, as mentioned, testing with hotwired/turbo-rails, I may write a few more tests. This will cause merge conflicts with #3004, so I'd like to merge this. Thoughts? |
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At present, some code paths will not close the app body. Add code to always hold a reference to the app body, so when code calling
lowlevel_erroris executed, the reference to the app body is maintained.test_rack_server.rb - add test_hijack_body_close - test for above
Small refactor of test_puma_server.rb. Takes too damn long.
test_puma_server.rb - add
test_lowlevel_error_body_closeto verify body close call when lowlevel_errorCloses #2999.
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.