Allow header values to be arrays (Rack 3) #2936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateberkopec
reviewed
Sep 9, 2022
test/test_response_header.rb
Outdated
|
|
||
| def send_http_and_read(req) | ||
| send_http(req).read | ||
| send_http(req).sysread 10_240 |
Member
Author
There was a problem hiding this comment.
read is evil. I was working on this, and with read, the new test took 20 sec. With sysread, it was what it should be.
But, then the Windows tests (only Ruby 3.1 and later), weren't getting the full response. But, using PR #2896, no problem.
Some of the issue is using the same Process for the server and client...
Member
There was a problem hiding this comment.
I see 👍 Lets refactor the magic number into a constant somwhere then.
Member
Author
There was a problem hiding this comment.
Done. Added comment also, as the value is dependent on the tests. I've used looping code for responses with unknown length...
nateberkopec
reviewed
Sep 9, 2022
nateberkopec
reviewed
Sep 9, 2022
nateberkopec
reviewed
Sep 9, 2022
nateberkopec
reviewed
Sep 9, 2022
Member
nateberkopec
left a comment
nateberkopec
left a comment
There was a problem hiding this comment.
Just left some thoughts.
MSP-Greg
force-pushed
the
00-rack-conform
branch
from
63dc9ec to
955cc92
Compare
MSP-Greg
force-pushed
the
00-rack-conform
branch
from
955cc92 to
97ed909
Compare
JoeDupuis
pushed a commit
to JoeDupuis/puma
that referenced
this pull request
May 28, 2023
* request.rb - allow header array value * test_response_header.rb - add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2931
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.