Skip to content

log_writer.rb - refactor, add internal_write method #2888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MSP-Greg merged 1 commit into from
Jun 1, 2022
Merged

log_writer.rb - refactor, add internal_write method #2888

MSP-Greg merged 1 commit into from
Jun 1, 2022

Conversation

@MSP-Greg
Copy link
Member

@MSP-Greg MSP-Greg commented May 30, 2022

Description

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg MSP-Greg merged commit 37b7832 into puma:master Jun 1, 2022
@MSP-Greg MSP-Greg deleted the 00-log-writer-2 branch June 4, 2022 16:03
JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this pull request Sep 9, 2022
@MSP-Greg @JuanitoFatas
log_writer.rb - add internal_write method (puma#2888)
e126af1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dentarg dentarg dentarg approved these changes

Assignees

No one assigned

Labels

refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MSP-Greg @dentarg