Refactor: Extract prune_bundler code into its own class (no logic change) #2797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyshields
changed the title
johnnyshields
changed the title
johnnyshields
force-pushed
the
refactor-prune-bundler
branch
from
201b626 to
5f43b7d
Compare
Member
|
Nice, good catch. |
nateberkopec
added
waiting-for-changes
Member
|
Hey @johnnyshields - if you could rebase this on top of master (which now has your other PR's changes), I can merge. |
Contributor
Author
|
@nateberkopec |
JuanitoFatas
pushed a commit
to JuanitoFatas/puma
that referenced
this pull request
Sep 9, 2022
Co-authored-by: shields <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a refactor which does not change any logic.
Currently, the code related to
prune_bundleris co-mingled into theLauncherclass. It can easily be extracted into its own class (I've named itBundlePruner) which will increase readability / reduce coupling inLauncher.