Refactor Launcher#run to increase readability (no logic change) #2795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… does not change any logic or ordering of operations.
johnnyshields
changed the title
johnnyshields
force-pushed
the
refactor-launcher-run-finished
branch
from
5c11ca7 to
d99227e
Compare
Member
|
Loving all the contributions @johnnyshields |
Contributor
Author
|
@nateberkopec by the way, I'm working on porting the Launcher + worker forking code from Puma to DelayedJob (with attribution of course). PR is here: collectiveidea/delayed_job#1160. Having copy-on-write will save me roughly $10,000 / month on my AWS bill, I'm currently memory-bound on my workloads. |
JuanitoFatas
pushed a commit
to JuanitoFatas/puma
that referenced
this pull request
Sep 9, 2022
…#2795) * Breaks Launcher#run into more functions to increase readability. This does not change any logic or ordering of operations. * Fix specs * More terse comment Co-authored-by: shields <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors Launcher#run to increase code readability. It does not change any logic or ordering of operations.
Reason: When reading the code of Launcher, initially it wasn't obvious to me how the
@statusvariable was used. This makes the control flow much more obvious.Things to watch out for:
do_run_finished,do_graceful_stop, etc. I'm happy to name these methods something other thando_xxx# do nothingcondition for@status == :exit. Not only is there no need to have a# do nothingcondition for it, it doesn't appear@status = :exitis actually set anywhere in Puma.