Support localhost integration in ssl_bind
#2764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
dentarg
force-pushed
the
ssl_bind-localhost-self-signed-fix
branch
from
6fba34a to
3f0ba58
Compare
Member
Author
|
Added missing |
Member
Author
|
macos-10.15 fail on ruby 2.2 was a strange one though 😕 |
dentarg
force-pushed
the
ssl_bind-localhost-self-signed-fix
branch
from
3f0ba58 to
f2b573c
Compare
Member
|
@dentarg Again, working on intermittent CI issues. macos-10.15 just does weird stuff. With (yet another) CI patch, I haven't had failures/errors except with 10.15... |
Close puma#2708 Close puma#2711 Co-authored-by: Marcin Olichwirowicz <[email protected]>
dentarg
force-pushed
the
ssl_bind-localhost-self-signed-fix
branch
from
f2b573c to
2b75c64
Compare
Member
Author
|
@MSP-Greg @nateberkopec WDYT? |
Member
Author
|
@nateberkopec could be included in next release? |
Member
|
Cheers @dentarg! Thanks for your patience. |
dentarg
added a commit
to Starkast/wikimum
that referenced
this pull request
Jan 27, 2022
No need to care about the port gotchas with foreman now that we can use ssl_bind in the Puma config: puma/puma#2764 Close #309
JuanitoFatas
pushed a commit
to JuanitoFatas/puma
that referenced
this pull request
Sep 9, 2022
Close puma#2708 Close puma#2711 Co-authored-by: Marcin Olichwirowicz <[email protected]> Co-authored-by: Marcin Olichwirowicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2708
Close #2711
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.