Rescue Errno::EBADF in Client#close
#2748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spotted happening in CI: https://github.com/puma/puma/runs/4095295281?check_suite_focus=true 2021-11-03 16:34:54 +0000 Exception handling servers: #<Errno::EBADF: Bad file descriptor>/Users/runner/work/puma/puma/lib/puma/client.rb:163:in `close': Bad file descriptor (Errno::EBADF) TestRackServer#test_large_post_body = from /Users/runner/work/puma/puma/lib/puma/client.rb:163:in `close'
Member
|
These macOS errors are getting a little frustrating. I had this and some other changes to test code, running more CI tonite. I don't think that I've seen the error on Ubuntu or Widows (or non-MRI?) , so I added a comment that |
MSP-Greg
approved these changes
Nov 3, 2021
Member
Author
Member
I don't think so, but I'll look at it again. I'm not sure what the cause is, but most of the problems have been in integration tests, which involve sub-processes. I.think. |
JuanitoFatas
pushed a commit
to JuanitoFatas/puma
that referenced
this pull request
Sep 9, 2022
Spotted happening in CI: https://github.com/puma/puma/runs/4095295281?check_suite_focus=true 2021-11-03 16:34:54 +0000 Exception handling servers: #<Errno::EBADF: Bad file descriptor>/Users/runner/work/puma/puma/lib/puma/client.rb:163:in `close': Bad file descriptor (Errno::EBADF) TestRackServer#test_large_post_body = from /Users/runner/work/puma/puma/lib/puma/client.rb:163:in `close'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted happening in CI: https://github.com/puma/puma/runs/4095295281?check_suite_focus=true
Related to #2700? (that changed
rescue ObjecttoIOError, Errno::EBADFand re-raises these two)See also #2312 that added
Errno::EBADF(and #2745 that improves on that)