Skip to content

Conversation

@MSP-Greg
Copy link
Member

@MSP-Greg MSP-Greg commented Apr 6, 2021

Description

Fixes event firings needed for systemd integration.

Closes #2572.

Note that @events.fire_on_stopped! was not called when in cluster mode, this also fixes that.

These tests take some time, I tested locally with two restarts, it passed.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg
Copy link
Member Author

MSP-Greg commented Apr 6, 2021

Note to self - cluster requires fork... 2nd CI should pass...

@nateberkopec nateberkopec added feature systemd waiting-for-review Waiting on review from anyone labels Apr 10, 2021
@MSP-Greg MSP-Greg added bug and removed feature labels Apr 20, 2021
@nateberkopec nateberkopec added this to the 5.3.0 milestone Apr 24, 2021
@nateberkopec nateberkopec merged commit f7a2d4e into puma:master May 5, 2021
@MSP-Greg MSP-Greg deleted the 00-i2572-systemd branch November 2, 2021 19:05
JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this pull request Sep 9, 2022
* systemd - fix event firing

* Update test_integration_systemd.rb

Co-authored-by: Nate Berkopec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug systemd waiting-for-review Waiting on review from anyone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[phased-restart] add support for systemd type notify

2 participants