Skip to content

Conversation

@cjlarose
Copy link
Member

@cjlarose cjlarose commented Oct 27, 2020

Description

Fixes #2454. A regression introduced in #2374 effectively broke preload_app. The puma master process would successfully preload the app before starting any workers, but fail to pass the preloaded app into the workers, who would then load their own version of the app, effectively defeating the point of preloading in the first place.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] or [ci skip] to the pull request title.
  • I have added appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@nateberkopec nateberkopec merged commit 87b480e into puma:master Oct 27, 2020
nateberkopec added a commit that referenced this pull request Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Puma 5.0.3 - preload_app loads app twice

2 participants