Skip to content

Fix chunked body decoding #2326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rkistner wants to merge 3 commits into from
Closed

Fix chunked body decoding #2326

rkistner wants to merge 3 commits into from

Conversation

@rkistner
Copy link
Contributor

@rkistner rkistner commented Jul 30, 2020 •
edited
Loading

Description

Closes #2325.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] the pull request title.
  • I have added appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR. - N/A
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly. - N/A
  • All new and existing tests passed, including Rubocop. Only ran tests in test/test_puma_server.rb locally

@nateberkopec nateberkopec added bug waiting-for-review Waiting on review from anyone labels Jul 31, 2020
@nateberkopec
Copy link
Member

nateberkopec commented Sep 4, 2020

Thanks for your contribution!

@nateberkopec
Copy link
Member

nateberkopec commented Sep 4, 2020

Merged: 3cdf905

@dentarg
Copy link
Member

dentarg commented Sep 4, 2020

For completeness, the two other commits: a2f5199, 552e8b5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug important! waiting-for-review Waiting on review from anyone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extra "\r" characters in chunked request body

3 participants

@rkistner @nateberkopec @dentarg