JRuby - Add Puma::MiniSSL::Engine#init? and #teardown methods, run all SSL tests #2317
Conversation
|
Please see Ubuntu TruffleRuby failure at: The macOS TruffleRuby job passed. |
|
Sorry about that, it looks like very weird transient, where it fails to unlock a lock it locked right above. So it's rather puzzling. |
No problem, the tests do have intermittent failure issues, some of which may be caused by parallel testing. I ran it it my fork with the same seed, and it passed: |
|
Small revision to better align MRI & JRuby SSL code. |
|
Re the discussion in your PR #2302 (which should be merged soon), I've tried to add It's passing here. If you have time, could you have a look at it? Some of the logging is different, I need to look a that some more, but some may also be due to differences in how Nio4r handles TCP/SSL/Unix sockets... |
|
Looks fine, I don't see any issues. |
|
@MSP-Greg can you rebase? @nateberkopec what about merging in this one? should make us not see in the output from the jruby tests, which would be nice (example) |
Add Puma::MiniSSL::Engine#init? and #teardown methods
5 participants
Description
JRuby implementation has always lacked Puma::MiniSSL::Engine#init? and #teardown methods, which are needed for use with SSL. Added methods and set all SSL tests to run with JRuby.
Your checklist for this pull request
[changelog skip]the pull request title.[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.