Removes connected_port, implements connected_ports #2076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This work starts the effort of removing connected_port from the specs. I have moved the code around a bit to get all connected_ports, the tests seem to pass in the appropriate areas. I want to verify this path before attempting to remove all UniquePort calls in the tests.
drews256
force-pushed
the
removes-connected-port
branch
from
a2cdc0b to
c4f6ac0
Compare
Member
Control servers should be able to "bind" to port 0, just like app servers, yes. |
2 tasks
| end | ||
|
|
||
| attr_reader :connected_port | ||
| attr_reader :connected_ports |
Member
There was a problem hiding this comment.
Not necessary as you define the method on the next line
nateberkopec
added a commit
that referenced
this pull request
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This work starts the effort of removing connected_port.
Referencing this issue:
#1996
I have moved the code around a bit to get all connected_ports, the tests seem
to pass in the appropriate areas.
I want to verify this path before attempting to remove all UniquePort calls in
the tests.
@nateberkopec Also, I wanna talk about removing UniquePort, as it seems like it is being used for some CLI specs and the
control-url. Is that approriate? Do we expect to be able to pass0in as the port for the control and be able to get it's connected port?Your checklist for this pull request
[changelog skip]to all commit messages.[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.