Remove confusing private call
#1882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hmmm... it looks like we were depending on it being public internally too! |
Member
|
What do you think - should we just remove the private and just say that method is public (which it has been...possibly for ever), or re-architect the code to deal with this somehow and make it actually private? |
Contributor
Author
|
Oh, then I think we should remove the confusing |
Member
|
Works for me @okuramasafumi |
`private` method doesn't make class methods private. (To make class methods private, use `private_class_method`.) That was confusing so it's removed.
okuramasafumi
force-pushed
the
private-class-method
branch
from
0d983ea to
e5ed3b5
Compare
okuramasafumi
changed the title
Rack::Handler::Puma.set_host_port_to_config privateprivate call
Contributor
Author
|
@nateberkopec OK, I modified this PR to just remove |
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
privatemethod doesn't make class methods private.(To make class methods private, use
private_class_method.)That was confusing so it's removed.