Add max_threads to Puma.stats
#1604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/max-thread-metric
branch
from
18d6e62 to
fb2ca4c
Compare
Currently we don’t know the max bound of the `pool_capacity` metric. We know `spawned` which is confusingly under the “running” keyword, however we don’t know if spawned is the highest it will possibly be. By adding `max_threads` we know the upper bound for `running` threads and therefore the upper bound for pool capacity. It should be noted that it’s not always guaranteed that puma will always create up to `max_threads`, a separate relationship between `running` and `max_threads` should be monitored as well (if min threads != max threads).
Contributor
Author
|
This is my failure: Any ideas? Seems unrelated. |
Contributor
Author
|
Can't run locally due to different unrelated error: |
Contributor
Author
|
Tests on master are borked for jruby, needs investigation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we don’t know the max bound of the
pool_capacitymetric. We knowspawnedwhich is confusingly under the “running” keyword, however we don’t know if spawned is the highest it will possibly be.By adding
max_threadswe know the upper bound forrunningthreads and therefore the upper bound for pool capacity.It should be noted that it’s not always guaranteed that puma will always create up to
max_threads, a separate relationship betweenrunningandmax_threadsshould be monitored as well (if min threads != max threads).