Skip to content

Raise EOFError if the socket has been closed #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tuwukee wants to merge 1 commit into from
Closed

Raise EOFError if the socket has been closed #1524

tuwukee wants to merge 1 commit into from

Conversation

@tuwukee
Copy link

@tuwukee tuwukee commented Mar 5, 2018 •
edited
Loading

ref #1502
ref #1507

Fixes errors:

Error reached top of thread-pool: EOFError (EOFError)

backtrace:
/Users/july/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/puma-3.11.2/lib/puma/client.rb:296:in `try_to_finish'
/Users/july/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/puma-3.11.2/lib/puma/client.rb:370:in `eagerly_finish'
/Users/july/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/puma-3.11.2/lib/puma/server.rb:280:in `block in run'
/Users/july/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/puma-3.11.2/lib/puma/thread_pool.rb:120:in `block in spawn_thread'

and

2018-03-05 11:02:07 +0300: Read error: #<EOFError: EOFError>

backtrace:
/Users/july/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/puma-3.11.2/lib/puma/client.rb:297:in `try_to_finish'
/Users/july/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/puma-3.11.2/lib/puma/client.rb:106:in `reset'
/Users/july/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/puma-3.11.2/lib/puma/server.rb:450:in `process_client'
/Users/july/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/puma-3.11.2/lib/puma/server.rb:302:in `block in run'
/Users/july/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/puma-3.11.2/lib/puma/thread_pool.rb:120:in `block in spawn_thread'

According to Socket's read_nonblock call nil can be returned only in case of an empty chunk - https://github.com/ruby/ruby/blob/96db72ce38b27799dd8e80ca00696e41234db6ba/io.c#L2905
We currently process it by returning nil from read_nonblock and then checking the chunk and raising EOFError (https://github.com/puma/puma/blob/master/lib/puma/client.rb#L292). The problem is that this exception is handled incorrectly but it can be fixed if we treat it as ConnectionError while calling read_nonblock.
Since EOFError is a subclass of IOError the exception will be handled within this block https://github.com/puma/puma/blob/master/lib/puma/client.rb#L283

@evanphx evanphx closed this in b9ff900 Mar 6, 2018
This was referenced Mar 14, 2018
Merged
Merged
Merged
Merged
Closed
Merged
This was referenced Mar 22, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tuwukee