do not blow up when RUBYOPT is not defined #1385
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
I suppose this PR shadows this one https://github.com/puma/puma/pull/1348/files. |
Contributor
Author
|
kinda ... was not sure what that did in addition to this "just fix it"
change ... so I made a new PR
…On Sat, Aug 5, 2017 at 11:33 AM, stereobooster ***@***.***> wrote:
I suppose this PR shadows this one https://github.com/puma/puma/
pull/1348/files.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1385 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAsZ5yDNfH6zPaled5f2i8JrPfWcyu5ks5sVLV5gaJpZM4OuhO6>
.
|
Member
Contributor
Author
|
added .dup for good measure ... might have produced weird errors if someone shells our from a puma process |
This was referenced Aug 16, 2017
dekellum
added a commit
to dekellum/lionfish
that referenced
this pull request
Aug 16, 2017
This reverts commit 853c01d. No longer needed with fix on puma master github: puma/puma#1344 puma/puma#1385
This was referenced Mar 12, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tried to run from master ... kaboom :D