Skip to content

Setup signal to trap SIGINT and gracefully stop server #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nateberkopec merged 1 commit into from
Aug 16, 2017
Merged

Setup signal to trap SIGINT and gracefully stop server #1377

nateberkopec merged 1 commit into from
Aug 16, 2017

Conversation

@shayonj
Copy link
Contributor

@shayonj shayonj commented Jul 27, 2017 •
edited
Loading

This way, when you send SIGINT to a server, when running via
rails s, a graceful shutdown/stop will be performed.

Before this, not trapping SIGINT would mean that either Rails::Server#start
or ::Rack::Server#start would be trapping SIGINT and exiting the process.

Fix for: #1362

References:

Replication of current/fixed behavior:

rails s
=> Booting Puma
=> Rails 5.1.2 application starting in development on http://localhost:3000
=> Run `rails server -h` for more startup options
Puma starting in single mode...
* Version 3.9.1 (ruby 2.3.3-p222), codename: Private Caller
* Min threads: 5, max threads: 5
* Environment: development
* Listening on tcp://0.0.0.0:3000
Use Ctrl-C to stop
^C- Gracefully stopping, waiting for requests to finish
=== puma shutdown: 2017-07-26 19:53:48 -0700 ===
- Goodbye!
Exiting

@shayonj shayonj mentioned this pull request Jul 27, 2017
Closed
@shayonj shayonj force-pushed the s/sigint-shutdown branch from b6e3982 to 0507d34 Compare July 27, 2017 02:55
@nateberkopec nateberkopec modified the milestone: 3.10.0 Aug 3, 2017
stereobooster
stereobooster reviewed Aug 3, 2017
View reviewed changes
lib/puma/launcher.rb
log "*** SIGTERM not implemented, signal based gracefully stopping unavailable!"
end

begin
Copy link
Contributor

@stereobooster stereobooster Aug 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lower in this file

if Puma.jruby?
  Signal.trap("INT") do

move those two together

Copy link
Contributor Author

@shayonj shayonj Aug 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Setup signal to trap SIGINT and gracefully stop server
d9a2358 
This way, when you send `SIGINT` to a running a server, when running via
`rails s`, a graceful shutdown/stop will be performed.

Before this, not trapping `SIGINT` would mean that either `Rails::Server#start`
or `::Rack::Server#start` would be trapping `SIGINT` and exiting the process.
@shayonj shayonj force-pushed the s/sigint-shutdown branch from 0507d34 to d9a2358 Compare August 5, 2017 22:23
@nateberkopec nateberkopec merged commit 8903eea into puma:master Aug 16, 2017
@nateberkopec nateberkopec mentioned this pull request Mar 27, 2018
Closed
This was referenced Mar 12, 2021
Closed
Open
Merged
Closed
Closed
Closed
Open
Open
Merged
Closed
Open
Merged
Open
@sync-by-unito sync-by-unito bot mentioned this pull request Apr 9, 2021
Closed
@schneems schneems mentioned this pull request Oct 16, 2025
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@stereobooster stereobooster stereobooster left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

3.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@shayonj @stereobooster @nateberkopec