Make write_nonblock available under SSL #1274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateberkopec
approved these changes
Apr 14, 2017
schneems
approved these changes
Apr 14, 2017
Contributor
schneems
left a comment
schneems
left a comment
There was a problem hiding this comment.
One minor typo. Other than that 👍
lib/puma/minissl.rb
Outdated
| # is that it means we'd have to have the ability to rewind | ||
| # an engine because after we write+extract, the socket | ||
| # write_nonblock call might raise an exception and later | ||
| # code would pass the same data in, but the engine would thing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation of
write_nonblockis not technically correct because it can block, but at least it gets past #1189 for the time being.The situation is that implementing it properly means having to be able to rewind the state of OpenSSL, which is hardly trivial.