Make get_dh1024 compatible with OpenSSL v1.1.0
#1178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following error:
```
../../../../ext/puma_http11/mini_ssl.c: In function ‘get_dh1024’:
../../../../ext/puma_http11/mini_ssl.c:90:5: error: dereferencing pointer to incomplete type ‘DH {aka struct dh_st}’
dh->p = BN_bin2bn(dh1024_p, sizeof(dh1024_p), NULL);
^~
```
These changes are based on the following patch to nginx:
<nginx/nginx@789abf2>
("SSL: default DH parameters compatible with OpenSSL 1.1.0").
Relevant parts of the nginx source code in their full context can be
found here:
<https://github.com/nginx/nginx/blob/release-1.10.2/src/event/ngx_event_openssl.c#L954-L980>.
For reference:
> *) Made DH and DH_METHOD opaque. The structures for managing DH objects
> have been moved out of the public header files. New functions for managing
> these have been added.
> [Matt Caswell]
<https://www.openssl.org/news/cl110.txt>
Fixes puma#1136.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following error:
These changes are based on the following patch to nginx:
nginx/nginx@789abf2
("SSL: default DH parameters compatible with OpenSSL 1.1.0").
Relevant parts of the nginx source code in their full context can be
found here:
https://github.com/nginx/nginx/blob/release-1.10.2/src/event/ngx_event_openssl.c#L954-L980.
For reference:
https://www.openssl.org/news/cl110.txt
Fixes #1136.