Skip to content

Really fix uninitialized constant Puma::StateFile #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nateberkopec merged 1 commit into from
Dec 13, 2016
Merged

Really fix uninitialized constant Puma::StateFile #1138

nateberkopec merged 1 commit into from
Dec 13, 2016

Conversation

@skull-squadron
Copy link

@skull-squadron skull-squadron commented Nov 20, 2016 •
edited
Loading 

$ bin/bundle exec pumactl -S tmp/puma.state restart
uninitialized constant Puma::StateFile

requiring puma doesn't require puma/state_file

Related: #901

@skull-squadron skull-squadron changed the title Fix uninitialized constant Puma::StateFile Really fix uninitialized constant Puma::StateFile Nov 20, 2016
@skull-squadron
Copy link
Author

skull-squadron commented Nov 20, 2016

(travis failure unrelated to this PR)

@nateberkopec nateberkopec mentioned this pull request Nov 20, 2016
Merged
@nateberkopec
Copy link
Member

nateberkopec commented Nov 20, 2016

Can't repro, but I haven't tried Rails yet (which it looks like you're doing, using the Rails bundler binstub?)

@skull-squadron
Copy link
Author

skull-squadron commented Nov 20, 2016

bundler, Rails and springified

@skull-squadron
Copy link
Author

skull-squadron commented Nov 20, 2016

Ruby 2.3.1

@skull-squadron
Copy link
Author

skull-squadron commented Nov 20, 2016 •
edited
Loading

Follow #1137 setup (basically rack and puma HEAD) and append to config/puma.rb

tmp_dir = File.expand_path('../../tmp', __FILE__)
pidfile "#{tmp_dir}/pids/puma.pid"
state_path "#{tmp_dir}/puma.state"

Run

bin/bundle exec puma

Then, in another terminal

bin/bundle exec pumactl -S tmp/puma.state restart

@nateberkopec nateberkopec modified the milestone: 3.7.0 Nov 23, 2016
@nateberkopec nateberkopec merged commit 56135d1 into puma:master Dec 13, 2016
@skull-squadron skull-squadron deleted the fix-uninitialized-constant-Puma-StateFile branch December 27, 2016 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

3.7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@skull-squadron @nateberkopec