-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Description
I don't think this problem every really went away for me, and I've spent today trying to fix it, with no luck.
It is present for me in 2.7.1, 2.9.0, and master branch.
Again, the fact that restart says "Command restart sent success" but the actual Puma process is down is pretty much horrible. It might be true that the command was sent successfully, but I don't care about that, I care if the #@?! Puma process has in fact restarted. The definition of success when you ask something to restart is if it comes back up. This is something Apache and Nginx understand, and they do report a failure if attempts to restart them fail.
Puma really has to block on this, and report failure when it happens.
For now I overrode the built in capistrano restart task to simply call stop and start. Not really a great solution.