Replies: 1 comment 4 replies
-
I agree |
Beta Was this translation helpful? Give feedback.
-
|
Thanks. I can do a PR within a few days, or... |
Beta Was this translation helpful? Give feedback.
-
|
Created an issue (#3218) so this can be picked up by anyone |
Beta Was this translation helpful? Give feedback.
-
|
See #3191. Are you okay with the commit/PR title? |
Beta Was this translation helpful? Give feedback.
-
|
Oh damn forgot about that PR 🫣 Yes, message in PR description looks good now, I can squash merge it |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Forwardable is currently used by server.rb & client.rb.
It is part of the standard library, but it's also available as a gem. Hence, it could be 'converted' to a bundled gem. Bundled gems need to be included as dependencies in gemspec files.
Server is delegating four methods of Binder, but Binder is also a available as an
attr_accessorin Server. I don't believe any of the delegated methods are used in Puma lib code, but they are used in test code.Client delegates one method (
closed?) from itsio.Since removing these would be an API change, I think we should remove Forwardable and do so manually.
See ruby/ruby@1e7ddfa7ea
Thoughts?
Beta Was this translation helpful? Give feedback.
All reactions