Review suugestions from @schneems

MSP-Greg · MSP-Greg · commit 233fc496f97f · 2025-07-31T12:22:16.000-05:00
diff --git a/docs/stats.md b/docs/stats.md
@@ -65,7 +65,8 @@ When Puma runs in single mode, these stats are available at the top level. When
   and is not used for any internal decisions, unlike `busy_theads`, which is usually a more useful stat.
 * max_threads: the maximum number of threads Puma is configured to spool per worker
 * requests_count: the number of requests this worker has served since starting
-
+* reactor_max: the maximum observed number of requests held in Puma's "reactor" which is used for asyncronously buffering request bodies. This stat is reset on every call, so it's the maximum value observed since the last stat call.
+* backlog_max: the maximum number of requests that have been fully buffered by the reactor and placed in a ready queue, but have not yet been picked up by a server thread. This stat is reset on every call, so it's the maximum value observed since the last stat call.
 
 ### cluster mode
 
diff --git a/lib/puma/cluster/worker_handle.rb b/lib/puma/cluster/worker_handle.rb
@@ -60,7 +60,7 @@ def ping!(status)
         # @todo remove each once Ruby 2.5 is no longer supported
         status.tr('}{"', '').strip.split(", ").each do |kv|
           cntr = 0
-          ary = kv.split(':').each do |t|
+          kv.split(':').each do |t|
             if cntr == 0
               k = t
               cntr = 1
diff --git a/lib/puma/dsl.rb b/lib/puma/dsl.rb
@@ -1273,6 +1273,7 @@ def fork_worker(after_requests=1000)
     # @deprecated Use {#max_keep_alive} instead.
     #
     def max_fast_inline(num_of_requests)
+      warn "[WARNING] `max_fast_inline` is deprecated use `max_keep_alive` instead"
       @options[:max_keep_alive] ||= Float(num_of_requests) unless num_of_requests.nil?
     end
 
diff --git a/test/test_puma_server.rb b/test/test_puma_server.rb
@@ -290,9 +290,6 @@ def test_puma_socket
     assert_equal body, data
   end
 
-
-
-
   def test_very_large_return
     giant = "x" * 2056610
 
@@ -1416,13 +1413,10 @@ def test_chunked_keep_alive_two_back_to_back
   def test_chunked_keep_alive_twenty_back_to_back
     req_count = 20
     requests = 0
-    body = nil
-    content_length = nil
 
     server_run(max_fast_inline: 21) { |env|
       requests += 1
-      body = env['rack.input'].read
-      content_length = env['CONTENT_LENGTH']
+      env['rack.input'].read
       [200, {}, ["Request_#{requests}"]]
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1273,6 +1273,7 @@ def fork_worker(after_requests=1000)`
`1273`	`1273`	`# @deprecated Use {#max_keep_alive} instead.`
`1274`	`1274`	`#`
`1275`	`1275`	`def max_fast_inline(num_of_requests)`
	`1276`	+ warn "[WARNING] `max_fast_inline` is deprecated use `max_keep_alive` instead"
`1276`	`1277`	`@options[:max_keep_alive] \|\|= Float(num_of_requests) unless num_of_requests.nil?`
`1277`	`1278`	`end`
`1278`	`1279`