Repository navigation
Commit 4a79549
authored
Invoke multi-argument-input functions positionally in PCL (#23571)
# Description
A function declared with `multiArgumentInputs` is now invoked in PCL by
passing its inputs **positionally** rather than as a single object
argument:
```hcl
# before
invoke("pkg:index:fn", { p1 = arg1, p2 = arg2 })
# now
invoke("pkg:index:fn", arg1, arg2)
```
The binder **rejects the object-argument form** for such functions with
a clear diagnostic (*"function … is declared with multi-argument inputs
and must be invoked with positional arguments…"*).
The optional `invokeOptions` object is passed as a final positional
argument, after one argument per input. To supply options while omitting
an optional input, pass `null` for that input:
```hcl
invoke("pkg:index:fn", arg1, null, { provider = p })
```
Anything beyond one argument per input plus the options object is
rejected.
## How it works
Positional invokes bind against a per-input signature `(token, input₁,
…, inputₙ, invokeOptions?)`, and a post-bind pass normalizes the call
back into the object-argument form. As a result the rest of PCL and
**every program generator continue to observe only the object form** —
no generator changes are needed, and PCL itself round-trips the
positional source.
The `l2-invoke-multi-argument` conformance program is updated to the
positional form (its PCL snapshots regenerate accordingly; TypeScript
output is unchanged because the normalized object form is identical).
The schema lookup shared by signature binding and the post-bind
normalization is factored into `invokeTokenArgument` and the binder's
`loadPackageSchema` helper.
## Testing
- New unit tests in `pkg/codegen/pcl/invoke_positional_test.go`:
object-argument form rejected, positional happy paths, optional-input
omission, `invokeOptions` as a trailing argument (with and without a
`null` placeholder), and too-many-arguments rejection. A `multiarg` test
schema fixture is added.
- `l2-invoke-multi-argument` conformance passes for PCL and TypeScript
(Go and Python remain expected failures, unchanged).
- `make lint_golang` is clean.
## Checklist
- [x] I have run `make lint` to verify my code passes the lint check
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] I have run `make changelog` and committed the
`changelog/pending/<file>` documenting my change1 parent 3212152 commit 4a79549
11 files changed
Lines changed: 436 additions & 21 deletions
File tree
- changelog/pending
- pkg
- codegen
- pcl
- testing/utils
- testing/pulumi-test-language/tests/testdata/l2-invoke-multi-argument
- sdk/pcl/cmd/pulumi-language-pcl/testdata
- eject-pcl/l2-invoke-multi-argument
- projects/l2-invoke-multi-argument
- round-tripped-project/l2-invoke-multi-argument
- tests/testdata/codegen
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
| |||
482 | 483 | | |
483 | 484 | | |
484 | 485 | | |
485 | | - | |
486 | | - | |
487 | | - | |
| 486 | + | |
488 | 487 | | |
489 | 488 | | |
490 | | - | |
491 | | - | |
492 | | - | |
| 489 | + | |
493 | 490 | | |
494 | 491 | | |
495 | 492 | | |
| |||
512 | 509 | | |
513 | 510 | | |
514 | 511 | | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
515 | 516 | | |
516 | 517 | | |
517 | 518 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
49 | 81 | | |
50 | 82 | | |
51 | 83 | | |
| |||
107 | 139 | | |
108 | 140 | | |
109 | 141 | | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
| 142 | + | |
| 143 | + | |
116 | 144 | | |
117 | 145 | | |
118 | 146 | | |
119 | | - | |
120 | 147 | | |
121 | 148 | | |
122 | 149 | | |
| |||
168 | 195 | | |
169 | 196 | | |
170 | 197 | | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
171 | 212 | | |
172 | 213 | | |
173 | 214 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
0 commit comments