Conversation
12 tasks
micprog
approved these changes
Jan 11, 2026
Member
micprog
left a comment
There was a problem hiding this comment.
LGTM 👍 It might make sense to go through the list of formats being tested and make sure it follows a consistent pattern, but I think this is already great! Bender's testing infrastructure is a very limited at the moment, so this will help improve consistency across versions!
Contributor
Author
|
The current test list was mostly derived from things that changed in #240 and that I wanted to check for regression. But since this is now a more general test, I agree that it would make sense to go over the list again and extend it! |
This reverts commit 9450a2e.
Runs with `--ignored` flag
32cd259 to
4a00c4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a comprehensive test suite
cli_regressionthat tests output of certain CLI commands against the old version. The way it works is that it installs a second "golden" bender and diffs the two outputs. The idea of those tests is not to freeze the script output of bender, but rather to give a feedback to the user whether there has been an unwanted regression.It's also added in the CI as a separate workflow that only triggers with PR. Running it on
pushtomasterwould not make any sense anyway since it would just comparemasteragainstmaster. Unfortunately, GitHub does not have any allow-failure feature that would just warn users (there is an open feature request since 5 years), meaning this CI workflow might indicate failure which can be ignored (after double-checking the diff output).Note on windows tests
There is an inconsistency in the script output in windows CI builds. The reason is that during checkout of a repository, git can transform newline characters to platform specific newline characters. For some reason, the git checkout done by the CI and
cargo install --gitchecks out differently, but specifying the newline character in.gitattributessolves this issue.TODOs: