Add warnings for nonexistend include directory and errors for missing path dependency#229
Conversation
fischeti
left a comment
fischeti
left a comment
There was a problem hiding this comment.
I think we already talked about this, and I just wanted to write down a current issue:
Bender does not consider targets correctly. For instance, an include directory that is guarded by a target and does not exists (yet):
- target: missing_folder
include_dirs:
- missing_folder/include
files:
- missing_folder/my_module.svthrows an error at the moment even if missing_folder is not specified as a target
mrogenmoserTT
force-pushed
the
missing_err
branch
2 times, most recently
from
82177c1 to
9efc21b
Compare
|
I adjusted the internals to only error if the missing include_directory is actually required 👍 |
fischeti
left a comment
fischeti
left a comment
There was a problem hiding this comment.
I think it should work now as intended. I still get an error from the snitch_cluster dependency due to this:
Whi can/should be fixed in the snitch cluster🤓
|
As far as I understand, there is no inherent harm in including a non-existent directory for any downstream tool, although it is bad practice, unlike if a file doesn't exist. Therefore, I think it makes the most sense to convert this error into a warning, not an error. |
mrogenmoserTT
force-pushed
the
missing_err
branch
from
63be0fe to
330da35
Compare
mrogenmoserTT
changed the title
…th dep in git dep
mrogenmoserTT
force-pushed
the
missing_err
branch
from
330da35 to
de16f38
Compare
3 participants
No description provided.