-
Notifications
You must be signed in to change notification settings - Fork 59
[bug] Fails to remove symlink on windows #251
Copy link
Copy link
Closed
Description
When using the bender clone command on Windows, it fails to remove the "old" checked out dependency's symlink:
error: Failed to remove symlink at path "XX". Access is denied. (os error 5)
As I understand it, symlinks on windows need to be removed with std::fs::remove_dir(path) and not std::fs::remove_file(path), which can be seen in src/cli.rs
Line 266 in 30ec37c
| std::fs::remove_file(path).map_err(|cause| { |
and src/cmd/clone.rs
Line 275 in 30ec37c
| std::fs::remove_file(link_path).map_err(|cause| { |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels