Fix up corner cases in table and code unescaping #776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This feels right to me, but it is a pretty big change and I would like the approval of @raphlinus. This was a blocking issue for the 0.10 version, so it is closer. Thanks! |
This was referenced Nov 4, 2023
notriddle
force-pushed
the
notriddle/unescape
branch
from
964b977 to
17ec582
Compare
notriddle
force-pushed
the
notriddle/unescape
branch
from
17ec582 to
965b9b4
Compare
notriddle
force-pushed
the
notriddle/unescape
branch
3 times, most recently
from
27fc31f to
08743d4
Compare
raphlinus
approved these changes
Jan 20, 2024
Collaborator
raphlinus
left a comment
raphlinus
left a comment
There was a problem hiding this comment.
This is a dauntingly large change for a relatively edge-casey bug, but I can't quickly see a better way to fix it. I'm satisfied with the degree of testing.
Note, the merge conflicts will need to be fixed before merging.
notriddle
force-pushed
the
notriddle/unescape
branch
from
08743d4 to
3995f54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #716