Skip to content

Comments

Fr translation#74

Merged
ruphy merged 5 commits intopubliccodeyml:masterfrom
fiorellabgs:fr-translation
Dec 3, 2019
Merged

Fr translation#74
ruphy merged 5 commits intopubliccodeyml:masterfrom
fiorellabgs:fr-translation

Conversation

@fiorellabgs
Copy link
Contributor

@fiorellabgs fiorellabgs commented Nov 13, 2019 •
edited
Loading

French Translation

Content

A contribution to help to translate the documentation in French, started here : https://github.com/italia/publiccode.yml/pull/73. I'm focusing on schema.core.rst.
As it is, the document is partially translated.

Review

  • Ensure your files are written following RST specs (not MD!)
  • Italian version
  • English version
  • Example files
  • Ask for review

@libremente
Copy link
Member

libremente commented Nov 15, 2019

Hi @fiorellabgs and thanks a lot for your contribution! We will review this and provide you some feedback ASAP. 👍

@ruphy
Copy link
Member

ruphy commented Nov 15, 2019

Amazing!!!

@bzg
Copy link
Contributor

bzg commented Dec 2, 2019

Hi @ruphy - can I help getting this PR merged? @fiorellabgs and I would like to continue working on this together, possibly with @nclsppr, the merge would help a lot. Thanks!

@ruphy
Copy link
Member

ruphy commented Dec 2, 2019 via email

@ruphy ruphy merged commit f6f4147 into publiccodeyml:master Dec 3, 2019
@ruphy
Copy link
Member

ruphy commented Dec 3, 2019

The first version is in! Thanks a lot! 🎉

I merged this instead of #73 as it looked to me like more complete and you mentioned you are working with @nclsppr. Can you coordinate so I can close #73 ?

I will now set aside some hours to work on the translation infrastructure, the more the project develops, the more I fear the translations will diverge. See for example this issue: italia/publiccode-editor#92

@ruphy ruphy mentioned this pull request Dec 3, 2019
Merged
6 tasks
@bzg
Copy link
Contributor

bzg commented Dec 3, 2019

I merged this instead of #73 as it looked to me like more complete and you mentioned you are working with @nclsppr. Can you coordinate so I can close #73 ?

To be clear, we didn't plan to coordinate with @nclsppr but I'll work on this. More precisely, I'll review #73 and see if it is mergeable or if I can help rework it.

I will now set aside some hours to work on the translation infrastructure, the more the project develops, the more I fear the translations will diverge. See for example this issue: italia/publiccode-editor#92

Yes, i18n is always a challenge - let us know if we can help!

@bzg bzg deleted the fr-translation branch December 3, 2019 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fiorellabgs @libremente @ruphy @bzg