Spell out the up-to-date ruleset setting in the 5D audit summary#425
Merged
Conversation
The 5D audit summary called the setting "strict-off", a term used exactly once in the document. Section 6 spells the same setting out as "require branches up to date before merging" is off, and repeats it for develop as "up to date" is off. Use the section 6 phrasing so the audit summary and the ruleset description name the setting the same way. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #425 +/- ##
========================================
Coverage 66.89% 66.89%
========================================
Files 13 13
Lines 1160 1160
Branches 108 108
========================================
Hits 776 776
Misses 338 338
Partials 46 46 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates WORKFLOW.md documentation to replace the shorthand strict-off label in the 5D audit summary with the explicit branch-ruleset setting wording used elsewhere in the doc, keeping terminology consistent within the workflow/audit guide.
Changes:
- Replaces
strict-offin the 5D configuration-audit summary with the spelled-out"require branches up to date before merging" ... offphrasing.
The previous wording split the quoted setting name across a line break, so searching for the exact label failed, and it read "... merging" off" where section 6 reads "... merging" is off. Restructure the sentence so the list ends before the clause, keeping the quoted name intact on a single line. Reflow the rest of the paragraph, which had drifted to a 142-character line and two short ragged lines across the preceding edits. It now wraps consistently near the file's ~105-character width. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
WORKFLOW.md:592
- This sentence is still missing
isbefore**off**, so it doesn’t exactly match the section 6 phrasing (e.g., line 645: "..." is off) and reads a bit ungrammatically.
the `main`/`develop` rulesets enforce the required merge method + status check + signed commits, with
"require branches up to date before merging" **off**, and the repository settings (auto-merge, allowed
merge methods) are in place, reporting any drift. A missing or incorrect configuration item is a defect
Merged
ptr727
added a commit
that referenced
this pull request
Jul 18, 2026
Promotion of #425 to `main`. ## Contents | PR | Change | | --- | --- | | #425 | Spell out the up-to-date ruleset setting in the 5D audit summary | Replaces the one-off `strict-off` term with section 6's phrasing (`"require branches up to date before merging"` **off**), so the audit summary and the ruleset description name the setting identically. Review also caught that the first attempt split the quoted label across a line break, making it unsearchable -- fixed, and the paragraph reflowed to the file's ~105-character width after earlier edits had left a 142-character line. This closes out the terminology finding Copilot raised on #423, which was deferred there as out of scope for that promotion. ## Release impact: no auto-publish Docs-only. No shipped input touched, so no stable release fires. NuGet stays at 4.0.18.
This was referenced Jul 21, 2026
ptr727-codegen Bot
pushed a commit
to ptr727/LanguageTags
that referenced
this pull request
Jul 21, 2026
Updated [ptr727.Utilities](https://github.com/ptr727/Utilities) from 4.0.18 to 4.0.28. <details> <summary>Release notes</summary> _Sourced from [ptr727.Utilities's releases](https://github.com/ptr727/Utilities/releases)._ ## 4.0.28 ## What's Changed * Bump the nuget-deps group with 3 updates by @dependabot[bot] in ptr727/Utilities#411 * Document the README + HISTORY cspell CI scope in CODESTYLE by @ptr727 in ptr727/Utilities#413 * Document the README + HISTORY cspell CI scope (main-only) by @ptr727 in ptr727/Utilities#414 * Bump actions/setup-dotnet from 5.4.0 to 6.0.0 in the actions-deps group by @dependabot[bot] in ptr727/Utilities#415 * Bump actions/setup-dotnet from 5.4.0 to 6.0.0 in the actions-deps group by @dependabot[bot] in ptr727/Utilities#416 * Refresh repo-config carry to current reference; add self-audit carry by @ptr727 in ptr727/Utilities#417 * Remove repo-wide analyzer relaxation and honor test cancellation by @ptr727 in ptr727/Utilities#418 * Add Codecov coverage shield to the README build status by @ptr727 in ptr727/Utilities#419 * Promote develop to main by @ptr727 in ptr727/Utilities#420 * Correct WORKFLOW.md audit flow and NUGET_USERNAME secret store by @ptr727 in ptr727/Utilities#422 * Describe the 5D audit as reporting defects, not failing by @ptr727 in ptr727/Utilities#424 * Promote develop to main by @ptr727 in ptr727/Utilities#423 * Spell out the up-to-date ruleset setting in the 5D audit summary by @ptr727 in ptr727/Utilities#425 * Promote develop to main by @ptr727 in ptr727/Utilities#426 * Bump DavidAnson/markdownlint-cli2-action from 24.0.0 to 24.1.0 in the actions-deps group by @dependabot[bot] in ptr727/Utilities#429 * Bump the nuget-deps group with 1 update by @dependabot[bot] in ptr727/Utilities#431 **Full Changelog**: ptr727/Utilities@4.0.18...4.0.28 Commits viewable in [compare view](ptr727/Utilities@4.0.18...4.0.28). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the terminology nit Copilot raised on #423, which I deferred there as out of scope for that promotion.
strict-offappeared exactly once inWORKFLOW.md(the 5D audit summary). Section 6 spells the same setting out twice:main:"require branches up to date before merging" is **off**develop:"up to date" is **off**The summary now uses the section 6 phrasing, so both places name the setting identically.
The word "strict" survives at line 646 (
so the strict check would fail every release), which is correct -- that sentence is explaining why the setting is off, and "the strict check" is GitHub's own term for the behavior.Docs-only; no shipped input, so no release impact.