Add resilient HttpClientFactory and AOT-safe AssemblyInfo (v4.0) by ptr727 · Pull Request #392 · ptr727/Utilities

ptr727 · 2026-07-10T16:51:02Z

Summary

Introduces a reusable, resilient HTTP client factory and an AOT-safe assembly identity helper, and cuts the library to v4.0.

HttpClientFactory - built on Microsoft.Extensions.Http.Resilience (Polly v8) with retry, circuit breaker, and connection pooling. Exposes a shared singleton client, caller-owned clients, and the resilience handler (as DelegatingHandler, keeping Polly types off the public API). Tunable via HttpClientOptions (best-practice defaults, override only what you need).
AssemblyInfo - AOT-safe identity helper. For<T>() (typeof(T).Assembly) substitutes for Assembly.GetExecutingAssembly(), which is unreliable under Native AOT (dotnet/runtime#94200). Supplies the consuming app name/version and a default User-Agent.
Download now builds its client through the factory; TimeoutSeconds and all method signatures are unchanged (downloads now flow through the resilience pipeline).

AOT strategy - proven, not assumed

The library gates reference AOT verification behind an explicit PublishAot opt-in, suppressing only the advisory IL3058 (the Polly graph is not annotated IsAotCompatible; real trim/dynamic-code issues would surface as IL2xxx/IL3050).
The Sandbox is restructured into an explicit Main calling standalone, commentable sample classes and serves as a Native AOT smoke test. Published and run as Native AOT, it resolves identity identically to the managed run (AppName=Sandbox, UserAgent=Sandbox/<version>) and executes the full Polly retry pipeline - the definitive proof that identity resolution and Polly work under AOT.
Added a Sandbox AOT Publish task and a Sandbox (non-AOT) debug launch config.

Analyzer cleanups (folded in)

List<T> public members -> Collection<T> / ReadOnlyCollection<T> (CA1002, a breaking API change).
await using disposal now uses ConfigureAwait(false) (CA2007).
Test-code fixes for CA2000/CA1849/CA5394, and the test .editorconfig trimmed to only the required xUnit suppressions (CA1707, CA1515).

Docs

HISTORY.md v4.0 entry, README.md release notes, Polly added to cspell.

Verification

dotnet build - 0 warnings / 0 errors under TreatWarningsAsErrors.
dotnet test - 145 passed (12 new).
dotnet csharpier check and dotnet format style --verify-no-changes clean.
Native AOT publish + run: identity + Polly pipeline confirmed working.

🤖 Generated with Claude Code

Add a reusable HttpClientFactory built on Microsoft.Extensions.Http.Resilience (Polly) with retry, circuit breaker, and connection pooling, tunable via HttpClientOptions and exposing a shared client, caller-owned clients, and the resilience handler. Add AssemblyInfo, an AOT-safe identity helper whose For<T>() substitutes for Assembly.GetExecutingAssembly(). Route Download through the factory (signatures unchanged). Gate the library's reference AOT verification behind an explicit PublishAot opt-in (suppressing the advisory IL3058 for the unannotated Polly graph), and turn Sandbox into a Native AOT smoke test (Main + standalone sample classes) that proves identity resolution and the Polly pipeline run under Native AOT. Also resolve the analyzer cleanups: List<T> public members to Collection<T> / ReadOnlyCollection<T> (CA1002), await-using ConfigureAwait(false) disposal (CA2007), and test-code fixes for CA2000/CA1849/CA5394, trimming the test .editorconfig to only the required xUnit suppressions. Docs: HISTORY.md v4.0 entry, README.md release notes, cspell Polly term. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

codecov · 2026-07-10T16:51:47Z

Codecov Report

❌ Patch coverage is 83.49515% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.20%. Comparing base (1568ac1) to head (33cf593).

Files with missing lines	Patch %	Lines
Utilities/HttpClientFactory.cs	81.55%	16 Missing and 3 partials ⚠️
Utilities/FileEx.cs	73.17%	11 Missing ⚠️
Utilities/AssemblyInfo.cs	77.77%	0 Missing and 4 partials ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #392      +/-   ##
===========================================
+ Coverage    40.62%   46.20%   +5.58%     
===========================================
  Files           10       13       +3     
  Lines         1024     1160     +136     
  Branches        99      107       +8     
===========================================
+ Hits           416      536     +120     
- Misses         580      593      +13     
- Partials        28       31       +3

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

This PR evolves ptr727.Utilities into a v4.0 release by introducing a reusable resilient HTTP client factory (Polly v8 via Microsoft.Extensions.Http.Resilience), adding an AOT-safe assembly/application identity helper, and updating related APIs, docs, and tests to align with analyzer guidance and Native AOT verification.

Changes:

Add HttpClientFactory + HttpClientOptions (retry + circuit breaker + connection pooling) and update Download to use the factory.
Add AssemblyInfo for AOT-safe assembly identity and a default User-Agent, plus Sandbox samples to exercise identity + resilience under managed and Native AOT.
Apply analyzer-driven API adjustments (List<T> -> Collection<T> / ReadOnlyCollection<T>) and update tests/docs/versioning accordingly.

Reviewed changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
version.json	Bumps the library version to 4.0.
Directory.Packages.props	Adds `Microsoft.Extensions.Http.Resilience` package version.
Utilities/Utilities.csproj	Adds resilience package reference and gates reference-AOT verification behind `PublishAot`.
Utilities/HttpClientOptions.cs	Introduces configurable defaults for retry/circuit breaker/pooling/timeouts/user-agent/base address.
Utilities/HttpClientFactory.cs	Adds resilient `HttpClient` creation APIs (singleton + caller-owned + handler).
Utilities/AssemblyInfo.cs	Adds AOT-safe assembly identity + app name/version + default User-Agent helper.
Utilities/Download.cs	Routes downloads through `HttpClientFactory` while keeping existing signatures/timeout knob.
Utilities/Extensions.cs	Adds source-generated logging methods for HTTP retry and circuit breaker events.
Utilities/FileEx.cs	Updates public API to use safe collection types and applies async-disposal `ConfigureAwait(false)` patterns.
Utilities/StringHistory.cs	Changes exposed list to `ReadOnlyCollection<string>` and internalizes the mutable list.
Utilities/StringCompression.cs	Updates async disposal to use `ConfigureAwait(false)` via configured async disposable.
Utilities/GlobalUsings.cs	Adds `System.Collections.ObjectModel` global using for new public surface types.
Utilities/.editorconfig	Removes prior library-scoped analyzer relaxations (keeping only CA1711 exemption).
UtilitiesTests/HttpClientOptionsTests.cs	Adds tests asserting default `HttpClientOptions` values.
UtilitiesTests/HttpClientFactoryTests.cs	Adds tests for singleton/shared client, independent clients, user-agent behavior, and handler creation.
UtilitiesTests/AssemblyInfoTests.cs	Adds tests for `AssemblyInfo.For<T>()` and identity/user-agent properties.
UtilitiesTests/StringCompressionTests.cs	Switches test randomness to `RandomNumberGenerator` to satisfy security analyzers.
UtilitiesTests/StringCompressionAsyncTests.cs	Switches async test randomness to `RandomNumberGenerator` to satisfy security analyzers.
UtilitiesTests/FileExAsyncTests.cs	Uses `CancellationTokenSource.CancelAsync()` in async cancellation test paths.
UtilitiesTests/ExtensionsTests.cs	Uses `CancellationTokenSource.CancelAsync()` in async cancellation test paths.
UtilitiesTests/ConsoleTests.cs	Hardens `Console.Out` redirection by restoring original output in `finally`.
UtilitiesTests/.editorconfig	Tightens test-specific analyzer suppression set to only required xUnit exceptions.
Sandbox/Program.cs	Restructures Sandbox into an explicit `Main` that runs sample classes and returns an exit code.
Sandbox/AssemblyIdentitySample.cs	Adds a sample that validates AOT-safe identity resolution with explicit runtime checks.
Sandbox/HttpClientSample.cs	Adds a sample that deterministically exercises the retry pipeline via a failing local request.
.vscode/tasks.json	Adds a “Sandbox AOT Publish” task for Native AOT smoke testing.
.vscode/launch.json	Adds a “Sandbox (non-AOT)” debug launch configuration.
README.md	Updates release notes section for v4.0 highlights/breaking changes.
HISTORY.md	Adds v4.0 release entry detailing new APIs, AOT strategy, and breaking API changes.
cspell.json	Adds “Polly” to the allowed dictionary list.

Copilot

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated 2 comments.

Copilot AI review requested due to automatic review settings July 10, 2026 16:51

Copilot started reviewing on behalf of ptr727 July 10, 2026 16:51 View session

Copilot AI reviewed Jul 10, 2026

View reviewed changes

Comment thread Utilities/HttpClientFactory.cs Outdated

Retry HTTP timeouts while excluding caller cancellation

aeda598

Copilot AI review requested due to automatic review settings July 10, 2026 17:00

Copilot started reviewing on behalf of ptr727 July 10, 2026 17:00 View session

Copilot AI reviewed Jul 10, 2026

View reviewed changes

Comment thread version.json

Comment thread Utilities/StringHistory.cs Outdated

Comment thread Utilities/HttpClientFactory.cs

Cache StringHistory read-only view and note shared client lifetime

33cf593

Copilot AI review requested due to automatic review settings July 10, 2026 17:09

Copilot started reviewing on behalf of ptr727 July 10, 2026 17:10 View session

Copilot AI reviewed Jul 10, 2026

View reviewed changes

Comment thread Utilities/Extensions.cs

Comment thread Utilities/Extensions.cs

ptr727 merged commit 405af67 into develop Jul 10, 2026
12 checks passed

ptr727 deleted the feature/http-client-factory branch July 10, 2026 18:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add resilient HttpClientFactory and AOT-safe AssemblyInfo (v4.0)#392

Add resilient HttpClientFactory and AOT-safe AssemblyInfo (v4.0)#392
ptr727 merged 3 commits into
developfrom
feature/http-client-factory

ptr727 commented Jul 10, 2026

Uh oh!

codecov Bot commented Jul 10, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ptr727 commented Jul 10, 2026

Summary

AOT strategy - proven, not assumed

Analyzer cleanups (folded in)

Docs

Verification

Uh oh!

codecov Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Jul 10, 2026 •

edited

Loading